Directplay on Background#2198
Directplay on Background#2198TobiGr merged 3 commits intoTeamNewPipe:devfrom Redirion:directOnBackground
Conversation
theScrabi
left a comment
There was a problem hiding this comment.
Code is ok, please check QA.
could you please link or explain what you mean with QA? My change is extremely small and straightforward and tested. |
|
Quality Asurance. We need to check if everything works as intended. |
|
Ah. I thought you wanted me to check some sort of QA guideline for NewPipe. Thanks for the clarification. |
|
@theScrabi IMO, we have too many longpress menus. They have a bad UI and UX , becuase
I think we should replace the menus with some buttons/icons in the app bar. something like this (rather the second draft): Btw. Should I open a new ticket for further discussion on this? |
TobiGr
left a comment
There was a problem hiding this comment.
My comment above has nothing to do with the original purpose of this PR, As @theScrabi already said, code looks good and I didn't find any bugs during a short test.
|
@TobiGr this proposal looks god and fits better into the material design then the long press menus we have right now :) I think its a good idea. |
|
Oh, I just came across this PR... @Redirion I saw you added the |
|
I thought "start here on background" means that this video would be played directly and all videos below would be queued. The option added by me would just play the video without queing others. @Stypox |
|
It seems like that's not the meaning... That name is ambiguous |

closes #2187
See the issue description and discussion. (with pictures!)
Regarding difference between "Play on Background" (commit and branch name) vs. "Play in Background" (strings.xml): from developer perspective playback runs on background player while from user perspective playback runs in background. ;)
Tested on Android 7.1.2.